Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs + Trace websockets are not connecting #400

Closed
dvaldivia opened this issue Nov 18, 2020 · 1 comment · Fixed by #401
Closed

Logs + Trace websockets are not connecting #400

dvaldivia opened this issue Nov 18, 2020 · 1 comment · Fixed by #401
Assignees
@Alevsk @cesnietor
Labels
bug this needs to be fixed needed High Priority operator Operator Console
Projects
Console Version 1

Comments

@dvaldivia
Copy link
Collaborator

On the operator console the websocket based logs and trace screens are not connecting, this may be related to #390
@dvaldivia dvaldivia added bug this needs to be fixed needed High Priority operator Operator Console labels Nov 18, 2020
@dvaldivia dvaldivia added this to To do in Console Version 1 via automation Nov 18, 2020
@Alevsk
Copy link
Contributor

Alevsk commented Nov 18, 2020

Will investigate further, is this happening only on the operator console ui? (not the regular console ui)

Alevsk added a commit to Alevsk/console that referenced this issue Nov 18, 2020
@Alevsk
Fixes Console issue minio#400
b18b057 
Previously cookie path was set to Path="/api", this was a performance
improvement to tell the browser to send the cookie only to request with
that prefix, however also consume endpoints on Path="/ws", since rfc6265
doesnt support multiple paths or regular expressions in the path field
of a cookie we are back to use Path="/" which means send the cookie to
all request under the current domain.
@Alevsk Alevsk linked a pull request Nov 18, 2020 that will close this issue
Fixes Console issue #400 #401
Merged
@Alevsk Alevsk closed this as completed Nov 18, 2020
Console Version 1 automation moved this from To do to Done Nov 18, 2020
dvaldivia added a commit that referenced this issue Nov 18, 2020
@Alevsk @dvaldivia
Fixes Console issue #400 (#401)
f1db949 
Previously cookie path was set to Path="/api", this was a performance
improvement to tell the browser to send the cookie only to request with
that prefix, however also consume endpoints on Path="/ws", since rfc6265
doesnt support multiple paths or regular expressions in the path field
of a cookie we are back to use Path="/" which means send the cookie to
all request under the current domain.

Co-authored-by: Daniel Valdivia <hola@danielvaldivia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alevsk Alevsk

@cesnietor cesnietor

Labels
bug this needs to be fixed needed High Priority operator Operator Console
Projects
No open projects
Console Version 1
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Console issue #400 Alevsk/console
3 participants
@Alevsk @cesnietor @dvaldivia