Integration Test #1012
Merged
Integration Test #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
Alevsk,
adfost,
kaankabalak,
bexsoft and
jinapurapu
harshavardhana
previously requested changes
Sep 7, 2021
There was a problem hiding this comment.
Make sure to run these tests as part of GitHub CI/CD, we should be able to run MinIO server locally by just running how our SDKs do the tests.
https://github.com/minio/minio-go/blob/master/.github/workflows/go.yml#L41
|
@harshavardhana yes! that's the plan, I'm still making some updates to this PR |
dvaldivia
force-pushed
the
integration-tests
branch
from
14976c2
to
44e7a83
Compare
|
@harshavardhana done |
jinapurapu
previously approved these changes
Sep 13, 2021
dvaldivia
force-pushed
the
integration-tests
branch
from
2003a69
to
1172d11
Compare
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
dvaldivia
force-pushed
the
integration-tests
branch
from
1172d11
to
fe35fd1
Compare
bexsoft
approved these changes
Sep 13, 2021
Alevsk
approved these changes
Sep 13, 2021
dvaldivia
dismissed
harshavardhana’s stale review
Concern already addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests meant to be run with a live MinIO server
Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com