Connect MCS with Minio TLS/Custom CAs #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alevsk
force-pushed
the
https-minio
branch
2 times, most recently
from
e16760c
to
5181e1b
Compare
Alevsk
requested review from
dvaldivia,
harshavardhana,
bexsoft,
cesnietor and
aead
aead
reviewed
May 8, 2020
Alevsk
changed the title
dvaldivia
previously approved these changes
May 8, 2020
cesnietor
requested changes
May 8, 2020
| func newMcsCredentials(accessKey, secretKey, location string) (*credentials.Credentials, error) { | ||
| return credentials.NewSTSAssumeRole(getMinIOServer(), credentials.STSAssumeRoleOptions{ | ||
| stsEndpoint := getMinIOServer() | ||
| if stsEndpoint == "" { |
There was a problem hiding this comment.
Suggested change
| if stsEndpoint == "" { | |
| if strings.TrimSpace(stsEndpoint) == "" { |
else " " will not enter here, same for the ones below
cesnietor
reviewed
May 8, 2020
This PR adds support to connect MCS to minio instances running TLS with self-signed certificates or certificates signed by custom Certificate Authorities ``` export MCS_MINIO_SERVER_TLS_ROOT_CAS=file1,file2,file3 ``` Note: TLS Skip Verification is not supported unless there's a clear need for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to connect MCS to minio instances running TLS with
self-signed certificates or certificates signed by custom
Certificate Authorities
Note: TLS Skip Verification is not supported unless there's a clear need
for it