Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List buckets re-design #1058

Merged
merged 8 commits into from
Sep 20, 2021
Merged

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Sep 18, 2021

New Reactive design.

To Test this change you must use MinIO Master

Screen Shot 2021-09-17 at 6 55 41 PM

2021-09-17 18-55-13 2021-09-17 18_56_38

adfost
adfost previously approved these changes Sep 18, 2021
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
adfost
adfost previously approved these changes Sep 18, 2021
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review TextField component usage under ListBuckets

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Need to delete node_modules & make yarn install again to run this.

@dvaldivia dvaldivia merged commit 64e38ca into minio:master Sep 20, 2021
@dvaldivia dvaldivia deleted the list-buckets-redesin branch September 20, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants