-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List buckets re-design #1058
Merged
Merged
List buckets re-design #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
harshavardhana,
Alevsk,
adfost,
bexsoft and
jinapurapu
September 18, 2021 01:57
adfost
previously approved these changes
Sep 18, 2021
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
dvaldivia
force-pushed
the
list-buckets-redesin
branch
from
September 18, 2021 02:16
7c16c61
to
1336af4
Compare
adfost
previously approved these changes
Sep 18, 2021
bexsoft
requested changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review TextField component usage under ListBuckets
portal-ui/src/screens/Console/Buckets/ListBuckets/ListBuckets.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
bexsoft
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Need to delete node_modules & make yarn install
again to run this.
Alevsk
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Reactive design.
To Test this change you must use MinIO Master