Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed label size & added text alignment #112

Merged
merged 1 commit into from May 12, 2020
Merged

Fixed label size & added text alignment #112

merged 1 commit into from May 12, 2020

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented May 12, 2020

fixes #111

What does this do?

Changed label width for input forms & added text alignment to it.

How to test

  • Go into any form with multiple fields and check that input boxes get aligned (width) & labels are aligned to the right

@bexsoft bexsoft self-assigned this May 12, 2020
@bexsoft bexsoft added the UI User Interface label May 12, 2020
@bexsoft bexsoft changed the title Fixed label size & added text alignment [WIP] Fixed label size & added text alignment May 12, 2020
@bexsoft bexsoft added the WIP This PR is WIP and cannot be merged yet label May 12, 2020
@bexsoft bexsoft changed the title [WIP] Fixed label size & added text alignment Fixed label size & added text alignment May 12, 2020
@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label May 12, 2020
dvaldivia
dvaldivia previously approved these changes May 12, 2020
@cesnietor
Copy link
Collaborator

looks good just one on the Postgres configuration looks odd, it is the only one that is not of the same width.
Screen Shot 2020-05-12 at 10 48 55 AM

@bexsoft
Copy link
Collaborator Author

bexsoft commented May 12, 2020

looks good just one on the Postgres configuration looks odd, it is the only one that is not of the same width.
Screen Shot 2020-05-12 at 10 48 55 AM

Checking

@bexsoft
Copy link
Collaborator Author

bexsoft commented May 12, 2020

looks good just one on the Postgres configuration looks odd, it is the only one that is not of the same width.
Screen Shot 2020-05-12 at 10 48 55 AM

Checking

@cesnietor Reapplied lost style.

Screen Shot 2020-05-12 at 2 47 29 PM

@bexsoft bexsoft requested a review from dvaldivia May 12, 2020 19:48
@dvaldivia dvaldivia merged commit 48e7991 into minio:master May 12, 2020
@bexsoft bexsoft deleted the forms-fixes branch May 13, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input labels need to have the same width
4 participants