Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured settings page to use URL navigation #1138

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Oct 22, 2021

What does this do?

Restructured settings page to use URL navigation

How does it look?

Screen Shot 2021-10-21 at 19 05 14

Screen Shot 2021-10-21 at 19 05 02

Screen Shot 2021-10-21 at 19 04 50

Signed-off-by: Benjamin Perez benjamin@bexsoft.net

@bexsoft bexsoft self-assigned this Oct 22, 2021
@bexsoft bexsoft added the dependency Dependency, DO NOT MERGE YET label Oct 22, 2021
@bexsoft bexsoft force-pushed the settings-single-page branch 2 times, most recently from 0169da9 to 161c88d Compare October 22, 2021 01:35
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft removed the dependency Dependency, DO NOT MERGE YET label Oct 22, 2021
@dvaldivia dvaldivia merged commit a4de76c into minio:master Oct 22, 2021
jinapurapu added a commit to jinapurapu/console that referenced this pull request Oct 23, 2021
* Added functionality to delete icon on Policy Details screen, typo fix in delete policy modal

* Removed unneeded text

* Updated field names

Updated material-ui dependencies to mui 5 & fixed issues with migration (minio#1119)

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>

Restructured settings page to use URL navigation (minio#1138)

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>

Co-authored-by: Benjamin Perez <benjamin@bexsoft.net>

Changed background to white & added new shadow in title bar (minio#1141)

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>

Co-authored-by: Benjamin Perez <benjamin@bexsoft.net>

Bug: Tenant metrics not loading (minio#1142)

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Release v0.11.0

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Rebase with assets

WIP disable manage bucket button

added admin policy to haspermission

Disabled Manage Bucket button for users without admin policy

WIP update policy list to access Manage Bucket

Renamed variables

Release v0.11.0

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Rebase with assets

WIP disable manage bucket button

added admin policy to haspermission

Disabled Manage Bucket button for users without admin policy

Added missing import

Added functionality to delete icon on Policy Details screen (minio#1137)

* Added functionality to delete icon on Policy Details screen, typo fix in delete policy modal

* Removed unneeded text

* Updated field names

Updated material-ui dependencies to mui 5 & fixed issues with migration (minio#1119)

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>

Restructured settings page to use URL navigation (minio#1138)

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>

Co-authored-by: Benjamin Perez <benjamin@bexsoft.net>

Changed background to white & added new shadow in title bar (minio#1141)

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>

Co-authored-by: Benjamin Perez <benjamin@bexsoft.net>

Bug: Tenant metrics not loading (minio#1142)

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Release v0.11.0

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Rebase with assets

WIP disable manage bucket button

added admin policy to haspermission

Disabled Manage Bucket button for users without admin policy

WIP update policy list to access Manage Bucket

Renamed variables

Release v0.11.0

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Rebase with assets

WIP disable manage bucket button

added admin policy to haspermission

Disabled Manage Bucket button for users without admin policy

Added missing import

Added functionality to delete icon on Policy Details screen (minio#1137)

* Added functionality to delete icon on Policy Details screen, typo fix in delete policy modal

* Removed unneeded text

* Updated field names

Updated material-ui dependencies to mui 5 & fixed issues with migration (minio#1119)

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>

Restructured settings page to use URL navigation (minio#1138)

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>

Co-authored-by: Benjamin Perez <benjamin@bexsoft.net>

Changed background to white & added new shadow in title bar (minio#1141)

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>

Co-authored-by: Benjamin Perez <benjamin@bexsoft.net>

Bug: Tenant metrics not loading (minio#1142)

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Release v0.11.0

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Rebase with assets

WIP disable manage bucket button

added admin policy to haspermission

Disabled Manage Bucket button for users without admin policy

WIP update policy list to access Manage Bucket

Renamed variables

Release v0.11.0

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>

Rebase with assets

WIP disable manage bucket button

added admin policy to haspermission

Disabled Manage Bucket button for users without admin policy

Added missing import
@bexsoft bexsoft deleted the settings-single-page branch November 12, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants