-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructured settings page to use URL navigation #1138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
force-pushed
the
settings-single-page
branch
2 times, most recently
from
October 22, 2021 01:35
0169da9
to
161c88d
Compare
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
bexsoft
force-pushed
the
settings-single-page
branch
from
October 22, 2021 01:43
161c88d
to
31b58f5
Compare
dvaldivia
approved these changes
Oct 22, 2021
Alevsk
approved these changes
Oct 22, 2021
jinapurapu
added a commit
to jinapurapu/console
that referenced
this pull request
Oct 23, 2021
* Added functionality to delete icon on Policy Details screen, typo fix in delete policy modal * Removed unneeded text * Updated field names Updated material-ui dependencies to mui 5 & fixed issues with migration (minio#1119) Signed-off-by: Benjamin Perez <benjamin@bexsoft.net> Restructured settings page to use URL navigation (minio#1138) Signed-off-by: Benjamin Perez <benjamin@bexsoft.net> Co-authored-by: Benjamin Perez <benjamin@bexsoft.net> Changed background to white & added new shadow in title bar (minio#1141) Signed-off-by: Benjamin Perez <benjamin@bexsoft.net> Co-authored-by: Benjamin Perez <benjamin@bexsoft.net> Bug: Tenant metrics not loading (minio#1142) Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Release v0.11.0 Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Rebase with assets WIP disable manage bucket button added admin policy to haspermission Disabled Manage Bucket button for users without admin policy WIP update policy list to access Manage Bucket Renamed variables Release v0.11.0 Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Rebase with assets WIP disable manage bucket button added admin policy to haspermission Disabled Manage Bucket button for users without admin policy Added missing import Added functionality to delete icon on Policy Details screen (minio#1137) * Added functionality to delete icon on Policy Details screen, typo fix in delete policy modal * Removed unneeded text * Updated field names Updated material-ui dependencies to mui 5 & fixed issues with migration (minio#1119) Signed-off-by: Benjamin Perez <benjamin@bexsoft.net> Restructured settings page to use URL navigation (minio#1138) Signed-off-by: Benjamin Perez <benjamin@bexsoft.net> Co-authored-by: Benjamin Perez <benjamin@bexsoft.net> Changed background to white & added new shadow in title bar (minio#1141) Signed-off-by: Benjamin Perez <benjamin@bexsoft.net> Co-authored-by: Benjamin Perez <benjamin@bexsoft.net> Bug: Tenant metrics not loading (minio#1142) Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Release v0.11.0 Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Rebase with assets WIP disable manage bucket button added admin policy to haspermission Disabled Manage Bucket button for users without admin policy WIP update policy list to access Manage Bucket Renamed variables Release v0.11.0 Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Rebase with assets WIP disable manage bucket button added admin policy to haspermission Disabled Manage Bucket button for users without admin policy Added missing import Added functionality to delete icon on Policy Details screen (minio#1137) * Added functionality to delete icon on Policy Details screen, typo fix in delete policy modal * Removed unneeded text * Updated field names Updated material-ui dependencies to mui 5 & fixed issues with migration (minio#1119) Signed-off-by: Benjamin Perez <benjamin@bexsoft.net> Restructured settings page to use URL navigation (minio#1138) Signed-off-by: Benjamin Perez <benjamin@bexsoft.net> Co-authored-by: Benjamin Perez <benjamin@bexsoft.net> Changed background to white & added new shadow in title bar (minio#1141) Signed-off-by: Benjamin Perez <benjamin@bexsoft.net> Co-authored-by: Benjamin Perez <benjamin@bexsoft.net> Bug: Tenant metrics not loading (minio#1142) Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Release v0.11.0 Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Rebase with assets WIP disable manage bucket button added admin policy to haspermission Disabled Manage Bucket button for users without admin policy WIP update policy list to access Manage Bucket Renamed variables Release v0.11.0 Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Rebase with assets WIP disable manage bucket button added admin policy to haspermission Disabled Manage Bucket button for users without admin policy Added missing import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Restructured settings page to use URL navigation
How does it look?
Signed-off-by: Benjamin Perez benjamin@bexsoft.net