Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tenants list #1160

Merged
merged 2 commits into from
Oct 28, 2021
Merged

New tenants list #1160

merged 2 commits into from
Oct 28, 2021

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Oct 28, 2021 •
edited

Screen Shot 2021-10-27 at 6 37 53 PM

@dvaldivia dvaldivia self-assigned this Oct 28, 2021
bexsoft
bexsoft previously approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just a minor change in the license disclaimer

portal-ui/src/screens/Console/Tenants/TenantDetails/TenantDetails.tsx Outdated Show resolved Hide resolved
bexsoft
bexsoft approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx
Copy link
Member

Few Observations:
Empty State:
The refresh button can be hidden or We can add informative text below the refresh button . ( before any tenant is registered)

"No Tenants registered."

Screenshot from 2021-10-28 11-20-43

@dvaldivia
Copy link
Collaborator Author

@prakashsvmx good point, we have the same problem in other screens and we need to fix it, I'll address that for tenants on a separate tenant

prakashsvmx
prakashsvmx approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good to me.

@dvaldivia dvaldivia merged commit 7a5cc66 into minio:master Oct 28, 2021
@dvaldivia dvaldivia deleted the new-tenants-list branch October 28, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@bexsoft bexsoft bexsoft approved these changes

@Alevsk Alevsk Awaiting requested review from Alevsk

@adfost adfost Awaiting requested review from adfost

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@dvaldivia dvaldivia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvaldivia @prakashsvmx @bexsoft