Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groups page ux refactor #1183

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Groups page ux refactor #1183

merged 2 commits into from
Nov 3, 2021

Conversation

prakashsvmx
Copy link
Member

Make Groups page flows similar to Users page.

  1. Create Group (with or without members)
  2. Add/Edit members
  3. Add/Edit policies for the group.
  4. Delete Group
  5. Enable/Disable Group

And Some code formatting fix

@prakashsvmx prakashsvmx self-assigned this Nov 3, 2021
@prakashsvmx prakashsvmx mentioned this pull request Nov 3, 2021
Closed
@dvaldivia
Copy link
Collaborator

Tested. LGTM

bexsoft
bexsoft approved these changes Nov 3, 2021
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Test OK

@bexsoft bexsoft merged commit 4e7559f into minio:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft bexsoft approved these changes

@adfost adfost Awaiting requested review from adfost

@Alevsk Alevsk Awaiting requested review from Alevsk

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

Assignees

@prakashsvmx prakashsvmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prakashsvmx @dvaldivia @bexsoft