Fix z-index of MainError component #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaankabalak
requested review from
Alevsk,
adfost,
dvaldivia,
bexsoft and
jinapurapu
kaankabalak
force-pushed
the
main-error-z-index
branch
from
d3382ef
to
1d7be94
Compare
|
All, I built the assets before sending in the PR, but do we build the assets only on releases now? I can make the necessary changes to the PR if required. Thanks in advance for the help! |
|
@kaankabalak yes, we only send assets in release PRs now |
|
Thanks @dvaldivia, updating the PR now 👍 |
kaankabalak
force-pushed
the
main-error-z-index
branch
from
1d7be94
to
7d61b2b
Compare
dvaldivia
approved these changes
Nov 25, 2021
bexsoft
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1255