Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate end-to-end permission testing #1383

Merged
merged 28 commits into from Jan 15, 2022

Conversation

kaankabalak
Copy link
Contributor

@kaankabalak kaankabalak commented Jan 12, 2022

This PR sets up and uses the TestCafe framework to automate end-to-end permission testing.

To summarize, these tests involve the creation of users and policies via mc and uses them to try out various permission related operations. Therefore it requires multiple commands to initialize and clean them up.

The entirety of the process can be run using the env bash /portal-ui/tests/scripts/permissions.sh command; provided that:

  • TestCafe is installed globally (using the npm i -g testcafe command)
  • The user is on the console directory
  • Before the tests are run, the front-end needs to be built (using the yarn build command)
  • MinIO Server (on port 9000), MinIO Console (on port 9090) are both running

Fixes miniohq/engineering#254

Makefile Show resolved Hide resolved
@prakashsvmx
Copy link
Member

@kaankabalak please update all the new files to have year as 2022 in the license header.

@kaankabalak
Copy link
Contributor Author

@kaankabalak please update all the new files to have year as 2022 in the license header.

Will do @prakashsvmx

@kaankabalak
Copy link
Contributor Author

@kaankabalak please update all the new files to have year as 2022 in the license header.

Done

@kaankabalak kaankabalak changed the title Automate end-to-end permission testing [WIP] Automate end-to-end permission testing Jan 12, 2022
@kaankabalak
Copy link
Contributor Author

I have just realized that we had some UI changes after I have rebased the branch, I will update the tests shortly. You can hold off reviewing the PR until then.

@dvaldivia @prakashsvmx @bexsoft @Alevsk @jinapurapu @adfost @cniackz

@dvaldivia dvaldivia assigned Alevsk and kaankabalak and unassigned Alevsk and kaankabalak Jan 12, 2022
@kaankabalak kaankabalak changed the title [WIP] Automate end-to-end permission testing Automate end-to-end permission testing Jan 13, 2022
@kaankabalak
Copy link
Contributor Author

kaankabalak commented Jan 13, 2022

I have just realized that we had some UI changes after I have rebased the branch, I will update the tests shortly. You can hold off reviewing the PR until then.

@dvaldivia @prakashsvmx @bexsoft @Alevsk @jinapurapu @adfost @cniackz

I have fixed the tests that were failing after recent UI changes, therefore you can now review the sections that involve the tests. However, I will need some help making sure the action runs smoothly.

@kaankabalak kaankabalak force-pushed the permission-testing-final branch 4 times, most recently from 86bd745 to 9d31160 Compare January 13, 2022 06:37
@kaankabalak
Copy link
Contributor Author

@kaankabalak there's a merge conflict

Fixed the conflict @dvaldivia

A fix to this will be sent in future PRs after investigation
@kaankabalak
Copy link
Contributor Author

Seems like a test is randomly failing only on GitHub Actions, will investigate this and send a fix for this in a future PR.

bexsoft
bexsoft previously approved these changes Jan 14, 2022
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit 479fa34 into minio:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants