Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit service account policy API+UI #1545

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Edit service account policy API+UI #1545

merged 2 commits into from
Feb 11, 2022

Conversation

adfost
Copy link
Contributor

@adfost adfost commented Feb 10, 2022

Adds API and UI for editing service account policy.

@adfost adfost added the WIP This PR is WIP and cannot be merged yet label Feb 10, 2022
@adfost adfost self-assigned this Feb 10, 2022
@adfost adfost force-pushed the edit_service_account_policy_ui branch from 8aa5401 to f2568e5 Compare February 10, 2022 21:32
@adfost adfost removed the WIP This PR is WIP and cannot be merged yet label Feb 10, 2022
@adfost adfost requested a review from cniackz February 10, 2022 21:36
cniackz
cniackz approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@cniackz cniackz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works now.
Looks good to me.
Thank you @adfost for adding the tests!

bexsoft
bexsoft approved these changes Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit 2988de4 into minio:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cniackz cniackz cniackz approved these changes

@bexsoft bexsoft bexsoft approved these changes

@Alevsk Alevsk Awaiting requested review from Alevsk

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@adfost adfost

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adfost @cniackz @bexsoft @dvaldivia