Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update encryption configuration screen for tenant #1611

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Feb 22, 2022

How it looks

image
Screenshot from 2022-02-22 23-05-04
Screenshot from 2022-02-22 23-05-24

Signed-off-by: Lenin Alevski alevsk.8772@gmail.com

@Alevsk Alevsk added the WIP This PR is WIP and cannot be merged yet label Feb 22, 2022
@Alevsk Alevsk self-assigned this Feb 22, 2022
@dvaldivia dvaldivia changed the title [WI] Update encryption configuration screen for tenant [WIP] Update encryption configuration screen for tenant Feb 22, 2022
@Alevsk Alevsk changed the title [WIP] Update encryption configuration screen for tenant Update encryption configuration screen for tenant Feb 23, 2022
@Alevsk Alevsk removed the WIP This PR is WIP and cannot be merged yet label Feb 23, 2022
@cniackz
Copy link
Collaborator

cniackz commented Feb 28, 2022

Tested locally, it looks good to me:

Screen Shot 2022-02-28 at 11 53 56 AM

Screen Shot 2022-02-28 at 11 54 09 AM

cniackz
cniackz previously approved these changes Feb 28, 2022
Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
@Alevsk Alevsk requested a review from cniackz March 1, 2022 00:33
@dvaldivia dvaldivia merged commit 4fa2f16 into minio:master Mar 1, 2022
@Alevsk Alevsk deleted the operator-encryption-config branch March 1, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants