Splitting admin tests from users tests #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
requested review from
adfost,
Alevsk,
bexsoft,
dvaldivia,
harshavardhana,
jinapurapu,
kaankabalak and
prakashsvmx
cniackz
changed the title
dvaldivia
previously approved these changes
Feb 23, 2022
bexsoft
previously approved these changes
Feb 24, 2022
cniackz
dismissed stale reviews from prakashsvmx, bexsoft, and dvaldivia
via
0f826e0
kaankabalak
approved these changes
Feb 24, 2022
dvaldivia
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/miniohq/engineering/issues/541
In PR #1617
@prakashsvmx suggested the idea:
I believe this is a good idea and it will help us to differentiate the tests by separating them in different files.
And this is what I did on this task.