Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navigation support to object versions #1626

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Feb 25, 2022

What does this do?

Added navigation support to object versions

How does it look?

Screen Shot 2022-02-25 at 15 52 37

Signed-off-by: Benjamin Perez benjamin@bexsoft.net

@bexsoft bexsoft self-assigned this Feb 25, 2022
@bexsoft bexsoft changed the title Added navigation support to object versions [WIP]Added navigation support to object versions Feb 25, 2022
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft changed the title [WIP]Added navigation support to object versions Added navigation support to object versions Feb 26, 2022
@jinapurapu
Copy link
Contributor

Is there an indication which is the current version? All versions have the "Restore this version" action, so there I can't easily tell which is current version

@bexsoft
Copy link
Collaborator Author

bexsoft commented Feb 26, 2022

Is there an indication which is the current version? All versions have the "Restore this version" action, so there I can't easily tell which is current version

Current version is always the last one (v# indicator), We may add some colors for this, @oscarocastellanos What do you suggest?

Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

@bexsoft
Couple of observations:

  1. We can have delete at the version row to delete the specific version
  2. The tag count meta data at the version looks like mismatcing.
    Upload an object in a version enabled bucket -> Veirfy the tag count 0 -> Upload Another version (tag count 0) -> navigate to versions list of the object -> Add a Tag and check the tag and metadata tag count is 1( on the latest version because it should be added only to the latest version) -> click the old version. tag is not displayed but tag count is displayed as 1. Verify this with mc and observe that the tag count is 0 for this and no tag is associated.
Screenshot (older version is selected)

image

mc results

latest object version

$ mc stat --version-id "e3d34b9c-57a3-4583-98c0-74f67d83537a" local/test-v-bucket/spacing_missing.png
Name      : spacing_missing.png
Date      : 2022-02-28 16:16:24 IST 
Size      : 23 KiB 
ETag      : 79442ddb5341fd40d498e754813446cd 
VersionID : e3d34b9c-57a3-4583-98c0-74f67d83537a 
Type      : file 
Metadata  :
  Content-Type       : image/png 
  X-Amz-Tagging-Count: 1 

older object version

$ mc stat --version-id "4312210d-ebc6-4495-aa79-ba9490769be8" local/test-v-bucket/spacing_missing.png
Name      : spacing_missing.png
Date      : 2022-02-28 16:15:07 IST 
Size      : 23 KiB 
ETag      : 79442ddb5341fd40d498e754813446cd 
VersionID : 4312210d-ebc6-4495-aa79-ba9490769be8 
Type      : file 
Metadata  :
  Content-Type: image/png 

@bexsoft
Copy link
Collaborator Author

bexsoft commented Feb 28, 2022

Thank you @prakashsvmx ! I Will review these issues and send fix in the next PR. I will be changing details panels & how are we displaying information in there

@bexsoft bexsoft merged commit 3395d1c into minio:master Feb 28, 2022
@bexsoft bexsoft deleted the navigation-component branch February 28, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants