-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added navigation support to object versions #1626
Conversation
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
b4b036b
to
964df59
Compare
Is there an indication which is the current version? All versions have the "Restore this version" action, so there I can't easily tell which is current version |
Current version is always the last one (v# indicator), We may add some colors for this, @oscarocastellanos What do you suggest? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me 👍
@bexsoft
Couple of observations:
- We can have delete at the version row to delete the specific version
- The tag count meta data at the version looks like mismatcing.
Upload an object in a version enabled bucket -> Veirfy the tag count 0 -> Upload Another version (tag count 0) -> navigate to versions list of the object -> Add a Tag and check the tag and metadata tag count is 1( on the latest version because it should be added only to the latest version) -> click the old version. tag is not displayed but tag count is displayed as 1. Verify this withmc
and observe that the tag count is 0 for this and no tag is associated.
mc results
latest object version
$ mc stat --version-id "e3d34b9c-57a3-4583-98c0-74f67d83537a" local/test-v-bucket/spacing_missing.png
Name : spacing_missing.png
Date : 2022-02-28 16:16:24 IST
Size : 23 KiB
ETag : 79442ddb5341fd40d498e754813446cd
VersionID : e3d34b9c-57a3-4583-98c0-74f67d83537a
Type : file
Metadata :
Content-Type : image/png
X-Amz-Tagging-Count: 1
older object version
$ mc stat --version-id "4312210d-ebc6-4495-aa79-ba9490769be8" local/test-v-bucket/spacing_missing.png
Name : spacing_missing.png
Date : 2022-02-28 16:15:07 IST
Size : 23 KiB
ETag : 79442ddb5341fd40d498e754813446cd
VersionID : 4312210d-ebc6-4495-aa79-ba9490769be8
Type : file
Metadata :
Content-Type: image/png
Thank you @prakashsvmx ! I Will review these issues and send fix in the next PR. I will be changing details panels & how are we displaying information in there |
What does this do?
Added navigation support to object versions
How does it look?
Signed-off-by: Benjamin Perez benjamin@bexsoft.net