Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Add Tenant Configure Audit Log and Monitoring to their own tabs #1636

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Mar 1, 2022

Move's the configure settings for Prometheus and Audit Log to their own tabs, and allows to turn them off

Screen Shot 2022-02-28 at 8 07 02 PM

Screen Shot 2022-02-28 at 8 07 01 PM

Screen Shot 2022-02-28 at 8 13 21 PM

Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com

@dvaldivia dvaldivia self-assigned this Mar 1, 2022
@dvaldivia dvaldivia force-pushed the move-audit-monitoring-add-tenant branch 2 times, most recently from 7266d17 to 8b7e82f Compare March 1, 2022 06:32
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@dvaldivia dvaldivia force-pushed the move-audit-monitoring-add-tenant branch from 53f12e1 to 548a535 Compare March 1, 2022 08:00
@@ -158,7 +158,7 @@ const UpdateTenantModal = ({
label={"MinIO's Image"}
id={"minioImage"}
name={"minioImage"}
placeholder={"E.g. minio/minio:RELEASE.2022-01-08T03-11-54Z"}
placeholder={"E.g. minio/minio:RELEASE.2022-02-26T02-54-46Z"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something here to change this label automatically with the latest version?

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit 632c665 into minio:master Mar 1, 2022
@dvaldivia dvaldivia deleted the move-audit-monitoring-add-tenant branch March 1, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants