Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kbar in operator mode #1638

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Conversation

dvaldivia
Copy link
Collaborator

Screen Shot 2022-02-28 at 10 01 47 PM

Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com

@prakashsvmx
Copy link
Member

prakashsvmx commented Mar 1, 2022

@dvaldivia
Observation:
do we apply permissions while listing the actions for users with policy?
e.g : User with policy which denies admin actions. (users, groups etc... are not expected as they would redirect to bucket page when clicked because of policy)

image

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@dvaldivia
Copy link
Collaborator Author

@prakashsvmx aaah, we need to deal with this problem, right now we load the kbar option once and don't reload after the session is loaded (when we get the right access policy) so we would need to introduce something to re-evaluate the kbar menu after we get the access policy to avoid listing these

Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Changes look good to me. We can improve progressively

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 19dd7aa into minio:master Mar 1, 2022
@Alevsk Alevsk deleted the fix-kbar-operator-mode branch March 1, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants