Block PR Merge if coverage is below threshold (Currently 40%) #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
requested review from
adfost,
Alevsk,
bexsoft,
dvaldivia,
harshavardhana,
jinapurapu,
kaankabalak and
prakashsvmx
cniackz
changed the title
bexsoft
approved these changes
Mar 1, 2022
kaankabalak
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/miniohq/engineering/issues/555
Based on the documentation in this place:
https://docs.google.com/document/d/1tEBMSmpoCftvtgUYjCSzAGqWM1T-1OsHk7AxvUoq0VM/edit
Let's make this automatically, in the way that you can actually calculated the coverage of every PR in the repo.
That way if the coverage of all the test is below the threshold then we can reject the PR and cannot be merged.
Otherwise, if the PR's coverage is above the threshold then you can merge
I will be doing this as the next step to force the increment of the coverage by the developers.
Inspired by: https://blog.cloudflare.com/go-coverage-with-external-tests/