Multiple files upload refactor #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alevsk
requested review from
harshavardhana,
cniackz,
adfost,
dvaldivia,
prakashsvmx,
kaankabalak,
bexsoft and
jinapurapu
Alevsk
force-pushed
the
upload-files-refactor
branch
from
01aa680
to
4bfbcc9
Compare
|
Tested locally, wanted to see the red color:
Disconnected minio server while uploading big file to see the error and the new red color on the bar. If Permission Tests are passing then this PR looks good to me! |
cniackz
previously approved these changes
Mar 23, 2022
- failed uploaded objects progress bar shows in red color - fixed bug in where failed uploaded objects cannot be removed from listed objects in ObjectManager - display delete button for failed upload objects - display setErrorSnackMessage component after done uploading all objects with number of failed objects - fixed race condition bug during multiple objects upload, now we are using Promise.allSettled to handle synchronization between uploads Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
Alevsk
force-pushed
the
upload-files-refactor
branch
from
15cdc84
to
f4aeb6a
Compare
prakashsvmx
reviewed
Mar 24, 2022
portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/ListObjects.tsx
Show resolved
Hide resolved
prakashsvmx
approved these changes
Mar 24, 2022
adfost
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listed objects in ObjectManager
objects with number of failed objects
using Promise.allSettled to handle synchronization between uploads
Signed-off-by: Lenin Alevski alevsk.8772@gmail.com