Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant form validations #177

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Tenant form validations #177

merged 1 commit into from
Jun 19, 2020

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Jun 17, 2020

fixes #152

What does this do?

Implement validations in create tenant form

Screen Shot 2020-06-17 at 1 54 38 PM

Screen Shot 2020-06-17 at 1 54 31 PM

@bexsoft bexsoft self-assigned this Jun 17, 2020
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of these can be empty, for example, image service name and access/secret key, can you update the validation like this? then we can work on the design to reflect what's truly optional

   {
      fieldKey: "tenant-name",
      required: true,
      pattern: /^[a-z0-9-]{3,63}$/,
      customPatternMessage:
        "Name only can contain lowercase letters, numbers and '-'. Min. Length: 3",
      value: tenantName,
    },
    {
      fieldKey: "image",
      required: false,
      value: imageName,
    },
    {
      fieldKey: "service_name",
      required: false,
      value: serviceName,
    },
    {
      fieldKey: "volumes_per_server",
      required: true,
      value: volumesPerServer.toString(10),
    },
    {
      fieldKey: "volume_size",
      required: true,
      value: volumeConfiguration.size,
    },
    {
      fieldKey: "access_key",
      required: false,
      value: accessKey,
    },
    {
      fieldKey: "secret_key",
      required: false,
      value: secretKey,
    },

@cesnietor
Copy link
Collaborator

should we do a suggestion on Image e.g. "minio/minio:" as shadow or something since I think it was not working with only the version.

@dvaldivia
Copy link
Collaborator

@cesnietor we could have it be the placeholder maybe

@bexsoft
Copy link
Collaborator Author

bexsoft commented Jun 17, 2020

Yeah, we can put this information as a placeholder

@bexsoft
Copy link
Collaborator Author

bexsoft commented Jun 18, 2020

@dvaldivia @cesnietor PR updated with requested changes
Screen Shot 2020-06-17 at 8 31 38 PM

@bexsoft bexsoft requested a review from dvaldivia June 18, 2020 01:32
@dvaldivia dvaldivia merged commit 34ff3d7 into minio:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validations in create clusters modal
4 participants