Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: compress health diagnostics file when download #1821

Merged
merged 5 commits into from Apr 13, 2022
Merged

Fix: compress health diagnostics file when download #1821

merged 5 commits into from Apr 13, 2022

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Apr 11, 2022

  • subnet expects the generated health diagnostics file to be gz compressed to work

Signed-off-by: Lenin Alevski alevsk.8772@gmail.com

@Alevsk Alevsk requested a review from klauspost April 11, 2022 06:28
@Alevsk Alevsk self-assigned this Apr 11, 2022
dvaldivia
dvaldivia previously approved these changes Apr 11, 2022
View reviewed changes
bexsoft
bexsoft requested changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting errors trying to uncompress the file, is this expected?
Screen Shot 2022-04-11 at 12 07 54
Screen Shot 2022-04-11 at 12 07 47

@Alevsk
Copy link
Contributor Author

Alevsk commented Apr 11, 2022

I'm getting errors trying to uncompress the file, is this expected?

Screen Shot 2022-04-11 at 12 07 54 Screen Shot 2022-04-11 at 12 07 47

Can you please try it on incognito window or chrome browser to see if this is safari related , I cannot replicate it

@bexsoft
Copy link
Collaborator

bexsoft commented Apr 11, 2022

I'm getting errors trying to uncompress the file, is this expected?
Screen Shot 2022-04-11 at 12 07 54
Screen Shot 2022-04-11 at 12 07 47

Can you please try it on incognito window or chrome browser to see if this is safari related , I cannot replicate it

I'm using Chrome, Also tried with Firefox & Safari both on 5005 (with WS enabled) & 9090, same results are seen

@Alevsk
Fix: compress health diagnostics file when download
c4076eb 
- subnet expects the generated health diagnostics file to be gz compressed to work

Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
@Alevsk Alevsk force-pushed the fix-health-diagnostics-download branch from 87668ac to c4076eb Compare April 11, 2022 20:16
@dvaldivia
Copy link
Collaborator

same problem on safari file sizes mismatch if I download from firefox

@Alevsk
Copy link
Contributor Author

Alevsk commented Apr 12, 2022

@dvaldivia @bexsoft this may be M1 related, I was able to generate, download and decompress the file on Mac OSX intel using safari

@Alevsk
Copy link
Contributor Author

Alevsk commented Apr 12, 2022

We should merge this, right now this feature is not working so users cannot generate the right file, If M1 users complain we can ask them to use Chrome/Firefox to download the file

dvaldivia
dvaldivia approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.LGTM.

bexsoft
bexsoft approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as it seems like the issue is only with generated files on M1 CPU.

@dvaldivia dvaldivia merged commit 68f9019 into minio:master Apr 13, 2022
@Alevsk Alevsk deleted the fix-health-diagnostics-download branch April 13, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft bexsoft approved these changes

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@adfost adfost Awaiting requested review from adfost

@cniackz cniackz Awaiting requested review from cniackz

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@klauspost klauspost Awaiting requested review from klauspost

Assignees

@Alevsk Alevsk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alevsk @bexsoft @dvaldivia