Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added URL support to object view #1831

Merged
merged 2 commits into from Apr 14, 2022
Merged

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Apr 12, 2022

What does this do?

  • Added URL support to object view
  • Refactored & simplified requests

PLEASE PERFORM COMPLETE VALIDATION BEFORE APPROVING THIS PR

How does it look?

Screen Shot 2022-04-11 at 21 53 49

Signed-off-by: Benjamin Perez benjamin@bexsoft.net

dvaldivia
dvaldivia previously approved these changes Apr 12, 2022
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM.

@prakashsvmx
Copy link
Member

@bexsoft

Flow 1: Create a bucket -> upload Object -> Refresh -> Create new path (Observe the Crash)
i got the below error. Refreshing the browser also does not help.

Video:

MinIO-Console_Crash.mp4
```

Uncaught TypeError: Cannot read properties of null (reading 'length')
at ObjectDetailPanel.tsx:204:1
at invokePassiveEffectCreate (react-dom.development.js:23488:1)
at HTMLUnknownElement.callCallback (react-dom.development.js:3946:1)
at Object.invokeGuardedCallbackDev (react-dom.development.js:3995:1)
at invokeGuardedCallback (react-dom.development.js:4057:1)
at flushPassiveEffectsImpl (react-dom.development.js:23575:1)
at unstable_runWithPriority (scheduler.development.js:468:1)
at runWithPriority$1 (react-dom.development.js:11277:1)
at flushPassiveEffects (react-dom.development.js:23448:1)
at performSyncWorkOnRoot (react-dom.development.js:22270:1)
(anonymous) @ ObjectDetailPanel.tsx:204
invokePassiveEffectCreate @ react-dom.development.js:23488
callCallback @ react-dom.development.js:3946
invokeGuardedCallbackDev @ react-dom.development.js:3995
invokeGuardedCallback @ react-dom.development.js:4057
flushPassiveEffectsImpl @ react-dom.development.js:23575
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11277
flushPassiveEffects @ react-dom.development.js:23448
performSyncWorkOnRoot @ react-dom.development.js:22270
(anonymous) @ react-dom.development.js:11328
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11277
flushSyncCallbackQueueImpl @ react-dom.development.js:11323
flushSyncCallbackQueue @ react-dom.development.js:11310
scheduleUpdateOnFiber @ react-dom.development.js:21894
dispatchAction @ react-dom.development.js:16140
(anonymous) @ ObjectDetailPanel.tsx:232
Promise.then (async)
(anonymous) @ ObjectDetailPanel.tsx:221
invokePassiveEffectCreate @ react-dom.development.js:23488
callCallback @ react-dom.development.js:3946
invokeGuardedCallbackDev @ react-dom.development.js:3995
invokeGuardedCallback @ react-dom.development.js:4057
flushPassiveEffectsImpl @ react-dom.development.js:23575
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11277
flushPassiveEffects @ react-dom.development.js:23448
performSyncWorkOnRoot @ react-dom.development.js:22270
(anonymous) @ react-dom.development.js:11328
unstable_runWithPriority @ scheduler.development.js:468
runWithPriority$1 @ react-dom.development.js:11277
flushSyncCallbackQueueImpl @ react-dom.development.js:11323
flushSyncCallbackQueue @ react-dom.development.js:11310
discreteUpdates$1 @ react-dom.development.js:22421
discreteUpdates @ react-dom.development.js:3757
dispatchDiscreteEvent @ react-dom.development.js:5890



<details>

@bexsoft bexsoft added the WIP This PR is WIP and cannot be merged yet label Apr 13, 2022
@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label Apr 13, 2022
@bexsoft
Copy link
Collaborator Author

bexsoft commented Apr 13, 2022

@bexsoft

Flow 1: Create a bucket -> upload Object -> Refresh -> Create new path (Observe the Crash) i got the below error. Refreshing the browser also does not help.

Video:

Issue Fixed

- Added URL support to object view
- Refactored & simplified requests

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

  • Navigating a console address bar url from another browser where the user is logged in.
  • Create new path -> Upload -> Refresh
  • No session -> Path URL -> Navigates to bucket list (default)
  • With logged in session -> It navigates to the desired path/prefix

Changes look good to me 👍

@prakashsvmx
Copy link
Member

prakashsvmx commented Apr 14, 2022

@bexsoft There are console.log hope they are added for debugging if any issues. may be we can remove later ?

console.log("SET PATH");
console.log("STE");
console.log("1");
console.log("2");

@bexsoft
Copy link
Collaborator Author

bexsoft commented Apr 14, 2022

@bexsoft There are console.log hope they are added for debugging if any issues. may be we can remove later ?

console.log("SET PATH"); console.log("STE"); console.log("1"); console.log("2");

Yes, my fault :/, let me do another PR to remove this. Thank you! =D

@bexsoft bexsoft merged commit a30d29b into minio:master Apr 14, 2022
@bexsoft bexsoft deleted the object-url-select branch June 1, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants