New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added URL support to object view #1831
Conversation
7bf5176
to
a5856b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. LGTM.
Flow 1: Create a bucket -> upload Object -> Refresh -> Create new path (Observe the Crash) Video: MinIO-Console_Crash.mp4
```
Uncaught TypeError: Cannot read properties of null (reading 'length')
|
6ca327b
to
06cb003
Compare
Issue Fixed |
- Added URL support to object view - Refactored & simplified requests Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
06cb003
to
9ddb3dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
- Navigating a console address bar url from another browser where the user is logged in.
- Create new path -> Upload -> Refresh
- No session -> Path URL -> Navigates to bucket list (default)
- With logged in session -> It navigates to the desired path/prefix
Changes look good to me 👍
@bexsoft There are
|
Yes, my fault :/, let me do another PR to remove this. Thank you! =D |
What does this do?
PLEASE PERFORM COMPLETE VALIDATION BEFORE APPROVING THIS PR
How does it look?
Signed-off-by: Benjamin Perez benjamin@bexsoft.net