Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add site in a new page for site replication #1845

Merged
merged 2 commits into from Apr 14, 2022
Merged

Add site in a new page for site replication #1845

merged 2 commits into from Apr 14, 2022

Conversation

prakashsvmx
Copy link
Member

Add Site in a New page.

How does it look:

image

@prakashsvmx prakashsvmx self-assigned this Apr 14, 2022
@prakashsvmx prakashsvmx changed the title Add site in a new page Add site in a new page for site replication Apr 14, 2022
oscarocastellanos
oscarocastellanos requested changes Apr 14, 2022
View reviewed changes
Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Bullet points (blue squares) in help box doesn't match the alignment to their corresponding text. Please, make it match.
  • When able to save the form, the save button should be blue background with white text.

@dvaldivia
Copy link
Collaborator

@oscarocastellanos the save button behavior will work as expected

oscarocastellanos
oscarocastellanos approved these changes Apr 14, 2022
View reviewed changes
Copy link

@oscarocastellanos oscarocastellanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit ae34d88 into minio:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@oscarocastellanos oscarocastellanos oscarocastellanos approved these changes

@adfost adfost Awaiting requested review from adfost

@bexsoft bexsoft Awaiting requested review from bexsoft

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@prakashsvmx prakashsvmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prakashsvmx @dvaldivia @oscarocastellanos