Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Initial Time support to Prometheus dashboard #2099

Merged
merged 2 commits into from Jun 9, 2022

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Jun 7, 2022

What does this do?

Added Initial Time support to Prometheus dashboard metrics, also incremented initial time for data usage growth chart

How does it look?

Screen Shot 2022-06-07 at 14 34 55

@bexsoft bexsoft self-assigned this Jun 7, 2022
@bexsoft bexsoft added the WIP This PR is WIP and cannot be merged yet label Jun 7, 2022
@bexsoft bexsoft changed the title Added Initial Time support to Prometheus dashboard [WIP]Added Initial Time support to Prometheus dashboard Jun 7, 2022
@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label Jun 7, 2022
@bexsoft bexsoft changed the title [WIP]Added Initial Time support to Prometheus dashboard Added Initial Time support to Prometheus dashboard Jun 7, 2022
dvaldivia
dvaldivia previously approved these changes Jun 7, 2022
@cniackz
Copy link
Collaborator

cniackz commented Jun 7, 2022

I got prometheus working locally in port 9000 with these instructions https://docs.min.io/minio/baremetal/monitoring/metrics-alerts/collect-minio-metrics-using-prometheus.html?ref=con#minio-metrics-collect-using-prometheus
But how you test this on port 5005? 🤔

@bexsoft
Copy link
Collaborator Author

bexsoft commented Jun 7, 2022

I got prometheus working locally in port 9000 with these instructions https://docs.min.io/minio/baremetal/monitoring/metrics-alerts/collect-minio-metrics-using-prometheus.html?ref=con#minio-metrics-collect-using-prometheus But how you test this on port 5005? 🤔

You can start console server using this flag: CONSOLE_PROMETHEUS_URL=http://localhost:9091/ changing the port according your prometheus settings (just be aware that prometheus is using the same ports as MinIO & Console)

Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ignore this comment.

@cniackz cniackz self-requested a review June 8, 2022 02:00
Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we discuss this tomorrow? For me to show you my scenario, then we can decide if we change the Step value.

restapi/admin_info.go Outdated Show resolved Hide resolved
@cniackz
Copy link
Collaborator

cniackz commented Jun 8, 2022

My question is, do we want to show just an approximation of the usage or real data?...
If we just want an approximation then this change might be ok, but for some customers I bet this will be confusing as graph may not contain desired points in time.

Incremented initial time for data usage growth chart
@bexsoft
Copy link
Collaborator Author

bexsoft commented Jun 9, 2022

Setting Step to 10, will see how it behaves, in case something goes strange, we can increment this value

@dvaldivia dvaldivia merged commit 5a8e029 into minio:master Jun 9, 2022
@dvaldivia dvaldivia deleted the series-increment branch June 9, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants