New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce renders in User Name when adding a user #2106
Merged
bexsoft
merged 1 commit into
minio:master
from
cniackz:reduce-renders-when-adding-a-user
Jun 10, 2022
Merged
Reduce renders in User Name when adding a user #2106
bexsoft
merged 1 commit into
minio:master
from
cniackz:reduce-renders-when-adding-a-user
Jun 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
force-pushed
the
reduce-renders-when-adding-a-user
branch
3 times, most recently
from
June 8, 2022 20:39
ed6e7a7
to
3f0ac44
Compare
cniackz
changed the title
[WIP] - Reduce renders when adding a user
[WIP] - Isolate user component to prepare for reducing renders in that section.
Jun 8, 2022
cniackz
changed the title
[WIP] - Isolate user component to prepare for reducing renders in that section.
[WIP] - Isolate user component to prepare for reducing renders
Jun 8, 2022
cniackz
changed the title
[WIP] - Isolate user component to prepare for reducing renders
Isolate user component to prepare for reducing renders
Jun 8, 2022
cniackz
requested review from
dvaldivia,
jinapurapu,
bexsoft,
adfost,
Alevsk,
harshavardhana,
kaankabalak,
prakashsvmx and
reivaj05
June 8, 2022 20:44
dvaldivia
previously requested changes
Jun 8, 2022
cniackz
force-pushed
the
reduce-renders-when-adding-a-user
branch
from
June 9, 2022 00:39
3f0ac44
to
1f21915
Compare
cniackz
force-pushed
the
reduce-renders-when-adding-a-user
branch
from
June 9, 2022 12:49
1f21915
to
92390f6
Compare
cniackz
changed the title
Isolate user component to prepare for reducing renders
[WIP] - Isolate user component to prepare for reducing renders
Jun 9, 2022
cniackz
force-pushed
the
reduce-renders-when-adding-a-user
branch
from
June 9, 2022 21:26
92390f6
to
a5041d2
Compare
cniackz
changed the title
[WIP] - Isolate user component to prepare for reducing renders
Reduce renders in User Name when adding a user
Jun 9, 2022
dvaldivia
previously approved these changes
Jun 9, 2022
I will resolve the conflict later today or tomorrow morning. |
cniackz
force-pushed
the
reduce-renders-when-adding-a-user
branch
from
June 10, 2022 15:01
a5041d2
to
50ed018
Compare
cniackz
changed the title
Reduce renders in User Name when adding a user
[WIP] - Reduce renders in User Name when adding a user
Jun 10, 2022
cniackz
force-pushed
the
reduce-renders-when-adding-a-user
branch
from
June 10, 2022 17:44
50ed018
to
76c0aa5
Compare
cniackz
force-pushed
the
reduce-renders-when-adding-a-user
branch
from
June 10, 2022 19:41
76c0aa5
to
1775c9d
Compare
cniackz
changed the title
[WIP] - Reduce renders in User Name when adding a user
Reduce renders in User Name when adding a user
Jun 10, 2022
dvaldivia
approved these changes
Jun 10, 2022
Alevsk
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Reduce renders in User Name when adding a user (Notice only that field is being rendered, not the entire screen):