Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce renders in User Name when adding a user #2106

Merged
merged 1 commit into from Jun 10, 2022

Conversation

cniackz
Copy link
Collaborator

@cniackz cniackz commented Jun 8, 2022

What does this do?

Reduce renders in User Name when adding a user (Notice only that field is being rendered, not the entire screen):

reduce-renders

@cniackz cniackz self-assigned this Jun 8, 2022
@cniackz cniackz added the WIP This PR is WIP and cannot be merged yet label Jun 8, 2022
@cniackz cniackz force-pushed the reduce-renders-when-adding-a-user branch 3 times, most recently from ed6e7a7 to 3f0ac44 Compare June 8, 2022 20:39
@cniackz cniackz changed the title [WIP] - Reduce renders when adding a user [WIP] - Isolate user component to prepare for reducing renders in that section. Jun 8, 2022
@cniackz cniackz changed the title [WIP] - Isolate user component to prepare for reducing renders in that section. [WIP] - Isolate user component to prepare for reducing renders Jun 8, 2022
@cniackz cniackz changed the title [WIP] - Isolate user component to prepare for reducing renders Isolate user component to prepare for reducing renders Jun 8, 2022
@cniackz cniackz removed the WIP This PR is WIP and cannot be merged yet label Jun 8, 2022
portal-ui/src/screens/Console/Users/AddUserScreen.tsx Outdated Show resolved Hide resolved
@cniackz cniackz force-pushed the reduce-renders-when-adding-a-user branch from 3f0ac44 to 1f21915 Compare June 9, 2022 00:39
@cniackz cniackz dismissed dvaldivia’s stale review June 9, 2022 00:40

resetForm moved to the slice

@cniackz cniackz requested a review from dvaldivia June 9, 2022 00:40
@cniackz cniackz force-pushed the reduce-renders-when-adding-a-user branch from 1f21915 to 92390f6 Compare June 9, 2022 12:49
@cniackz cniackz changed the title Isolate user component to prepare for reducing renders [WIP] - Isolate user component to prepare for reducing renders Jun 9, 2022
@cniackz cniackz added the WIP This PR is WIP and cannot be merged yet label Jun 9, 2022
@cniackz cniackz force-pushed the reduce-renders-when-adding-a-user branch from 92390f6 to a5041d2 Compare June 9, 2022 21:26
@cniackz cniackz changed the title [WIP] - Isolate user component to prepare for reducing renders Reduce renders in User Name when adding a user Jun 9, 2022
@cniackz cniackz removed the WIP This PR is WIP and cannot be merged yet label Jun 9, 2022
dvaldivia
dvaldivia previously approved these changes Jun 9, 2022
@cniackz
Copy link
Collaborator Author

cniackz commented Jun 9, 2022

I will resolve the conflict later today or tomorrow morning.

@cniackz cniackz force-pushed the reduce-renders-when-adding-a-user branch from a5041d2 to 50ed018 Compare June 10, 2022 15:01
@cniackz cniackz requested a review from dvaldivia June 10, 2022 15:01
@cniackz cniackz changed the title Reduce renders in User Name when adding a user [WIP] - Reduce renders in User Name when adding a user Jun 10, 2022
@cniackz cniackz added the WIP This PR is WIP and cannot be merged yet label Jun 10, 2022
@cniackz cniackz force-pushed the reduce-renders-when-adding-a-user branch from 50ed018 to 76c0aa5 Compare June 10, 2022 17:44
@cniackz cniackz force-pushed the reduce-renders-when-adding-a-user branch from 76c0aa5 to 1775c9d Compare June 10, 2022 19:41
@cniackz cniackz changed the title [WIP] - Reduce renders in User Name when adding a user Reduce renders in User Name when adding a user Jun 10, 2022
@cniackz cniackz removed the WIP This PR is WIP and cannot be merged yet label Jun 10, 2022
@bexsoft bexsoft merged commit 5d591b1 into minio:master Jun 10, 2022
@cniackz cniackz deleted the reduce-renders-when-adding-a-user branch June 10, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants