Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove history library #2119

Merged
merged 9 commits into from Jun 13, 2022
Merged

Remove history library #2119

merged 9 commits into from Jun 13, 2022

Conversation

reivaj05
Copy link
Contributor

No description provided.

@reivaj05 reivaj05 self-assigned this Jun 11, 2022
@dvaldivia
Copy link
Collaborator

Permissions Test Part 1 and Permissions Test Part 8 keep failing

@reivaj05 reivaj05 dismissed dvaldivia’s stale review June 13, 2022 18:26

Tests passing now

@reivaj05 reivaj05 changed the title Use navigate instead of push Remove history library Jun 13, 2022
bexsoft
bexsoft approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit b02c37b into minio:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft bexsoft approved these changes

@cniackz cniackz Awaiting requested review from cniackz

@adfost adfost Awaiting requested review from adfost

@Alevsk Alevsk Awaiting requested review from Alevsk

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

Assignees

@reivaj05 reivaj05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reivaj05 @dvaldivia @bexsoft