Added decimal support to bucket quota selectors #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested review from
Alevsk,
cniackz,
reivaj05,
adfost,
dvaldivia,
prakashsvmx and
jinapurapu
prakashsvmx
reviewed
Jun 15, 2022
There was a problem hiding this comment.
Observations:
- We could apply same changes in Create Bucket screen as well.
- With
mc
mc admin bucket quota local/b-bucket --hard 1.7GB
Successfully set bucket quota of 1.6 GiB with hard type on `b-bucket`
mc admin bucket quota local/b-bucket
Bucket `b-bucket` has hard quota of 1.6 GiB
so as per the above mc commands, ~0.1 is lesser capacity is set for quota
but if we update from the UI, it sets the exact value.
e.g 2.6 GB gets updated as 2.6 GB
Otherwise changes look good to me 👍
I think this is related to GB vs GiB conversion, so this should be expected |
|
Found issues with Add Bucket form validation. Will fix them on this PR as well |
bexsoft
changed the title
- Fixed an issue with calculateBytes function - Fixed add bucket validation form Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
bexsoft
changed the title
dvaldivia
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
How does it look?
Signed-off-by: Benjamin Perez benjamin@bexsoft.net