Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To migrate react warning test #2273

Merged
merged 7 commits into from
Sep 6, 2022

Conversation

cniackz
Copy link
Collaborator

@cniackz cniackz commented Aug 25, 2022

Objective:

Migrate react test to Datacenter

Testing:

cniackz/twin#4

Requirements:

https://github.com/miniohq/engineering-tools/pull/23

Relevant section added:

# Install yarn on self-hosted runner due to:
# https://github.com/actions/setup-node/issues/182
RUN curl -fsSL https://deb.nodesource.com/setup_18.x | bash -
RUN apt install -y nodejs
RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
RUN echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
RUN apt update
RUN apt install -y yarn

Tested in our Runners:

Screen Shot 2022-09-06 at 4 00 17 PM

@cniackz cniackz changed the title Migrate react warning test [WIP] - Migrate react warning test Aug 25, 2022
@cniackz cniackz self-assigned this Aug 25, 2022
@cniackz cniackz force-pushed the migrate-react-warning-test branch 16 times, most recently from 8defc0f to 641fa51 Compare August 26, 2022 12:43
@cniackz cniackz requested a review from dvaldivia August 26, 2022 12:43
@cniackz cniackz changed the title [WIP] - Migrate react warning test Migrate react warning test Aug 26, 2022
@cniackz
Copy link
Collaborator Author

cniackz commented Aug 26, 2022

@dvaldivia when you get a chance, please use Dockerfile from PR: https://github.com/miniohq/engineering-tools/pull/23 to create new Runners, that way React Code Has No Warnings & is Prettified, then Make Assets tests will be properly executed in this PR 👍

@cniackz
Copy link
Collaborator Author

cniackz commented Aug 29, 2022

AR Cesar: Search for another action that does this for you so you don't install yarn on your container.

@cniackz
Copy link
Collaborator Author

cniackz commented Aug 29, 2022

@pjuarezd after some research, yarn is pre-installed on the github-hosted runners and setup-node action is not installing this for us in a self-hosted runner not even when performing the cache step:

Some people already recommended to install this on the self-hosted runner, so this is why we need this section to be added:

# Install yarn on self-hosted runner due to:
# https://github.com/actions/setup-node/issues/182
RUN curl -fsSL https://deb.nodesource.com/setup_18.x | bash -
RUN apt install -y nodejs
RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
RUN echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
RUN apt update
RUN apt install -y yarn

@cniackz cniackz changed the title Migrate react warning test To migrate react warning test Sep 6, 2022
@bexsoft bexsoft removed the blocked label Sep 6, 2022
@bexsoft bexsoft merged commit 524258a into minio:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants