Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiers permission UI fix #2310

Merged
merged 4 commits into from Sep 15, 2022
Merged

Conversation

jinapurapu
Copy link
Contributor

@jinapurapu jinapurapu commented Sep 13, 2022

Fixes incorrect UI for users with standalone admin:SetTier or admin:ListTier permissions:

  • Tiers tab no longer on Menu if admin:ListTier not enabled
  • Helpbox on empty Tiers landing screen prompts user with only admin:ListTier permission to enable admin:SetTier
  • Create Tier button disabled if admin:SetTier not enabled , tooltip advising how to configure permissions

Screen Shot 2022-09-14 at 12 35 15 PM

@bexsoft
Copy link
Collaborator

bexsoft commented Sep 14, 2022

Is this screenshot from your Linux machine? Which browser are you testing on?

@jinapurapu
Copy link
Contributor Author

jinapurapu commented Sep 14, 2022

Is this screenshot from your Linux machine? Which browser are you testing on?

This is in Safari, here is what it looks like in Chrome on Linux:
Screenshot from 2022-09-14 12-35-41

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 77f62e1 into minio:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants