Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIs to define mTLS configuration for KES #235

Merged
merged 1 commit into from
Aug 8, 2020
Merged

APIs to define mTLS configuration for KES #235

merged 1 commit into from
Aug 8, 2020

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Aug 6, 2020 •
edited

  • Adding support for user to define KES mTLS configuration for Vault and Gemalto
  • Upgraded to Operator Version 3.0.10

@Alevsk Alevsk self-assigned this Aug 6, 2020
@Alevsk Alevsk added WIP This PR is WIP and cannot be merged yet security labels Aug 6, 2020
dvaldivia
dvaldivia reviewed Aug 6, 2020
View reviewed changes
restapi/admin_tenants.go Outdated Show resolved Hide resolved
dvaldivia
dvaldivia previously approved these changes Aug 6, 2020
View reviewed changes
bexsoft
bexsoft previously approved these changes Aug 6, 2020
View reviewed changes
Alevsk
Alevsk commented Aug 6, 2020
View reviewed changes
restapi/admin_tenants.go Outdated Show resolved Hide resolved
cesnietor
cesnietor requested changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please Abstract code, also we need to delete all the secrets that are being created if it fails in any of the steps.

@Alevsk
Copy link
Contributor Author

Alevsk commented Aug 6, 2020

could you please Abstract code, also we need to delete all the secrets that are being created if it fails in any of the steps.

ill abstract and refactor the code

@Alevsk Alevsk dismissed stale reviews from bexsoft and dvaldivia via 1c314ed August 7, 2020 02:47
@Alevsk Alevsk force-pushed the kes-client-certs-mtls branch 2 times, most recently from 1c314ed to 556217f Compare August 7, 2020 06:41
@Alevsk Alevsk removed the WIP This PR is WIP and cannot be merged yet label Aug 7, 2020
@Alevsk Alevsk changed the title [WIP] APIs to define mTLS configuration for KES APIs to define mTLS configuration for KES Aug 7, 2020
cesnietor
cesnietor previously approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alevsk Alevsk force-pushed the kes-client-certs-mtls branch 2 times, most recently from 7fa5c2a to f62c46f Compare August 7, 2020 07:48
@Alevsk Alevsk requested a review from cesnietor August 7, 2020 07:48
dvaldivia
dvaldivia previously approved these changes Aug 7, 2020
View reviewed changes
@Alevsk Alevsk requested a review from dvaldivia August 7, 2020 08:47
@Alevsk
APIs to define mTLS configuration for KES
cb982ce 
Adding support for user to define KES mTLS configuration for Vault and
Gemalto
@dvaldivia dvaldivia merged commit 8ec6d69 into minio:master Aug 8, 2020
@Alevsk Alevsk deleted the kes-client-certs-mtls branch November 20, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft bexsoft approved these changes

@cesnietor cesnietor Awaiting requested review from cesnietor

Assignees

@Alevsk Alevsk

Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Alevsk @cesnietor @dvaldivia @bexsoft