Allow tolerationSeconds to be empty on Zone tolerations Requests #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since toleration seconds can be empty, we were forcing it to be an integer defaulting to 0 which was creating a toleration with value 0 when value should have been nil.
dvaldivia
approved these changes
Aug 8, 2020
dvaldivia
reviewed
Aug 8, 2020
| be treated as 0 (evict immediately) by the system. | ||
| type: object | ||
| required: | ||
| - seconds |
There was a problem hiding this comment.
I thought this was allowed to be nil :S
There was a problem hiding this comment.
it is, that's the main purpose of this PR, zoneTolerationSeconds is not required, but if zoneTolerationSeconds is defined, then seconds is required.
dvaldivia
reviewed
Aug 8, 2020
| @@ -1233,12 +1226,18 @@ func parseTenantZoneRequest(zoneParams *models.Zone, annotations map[string]stri | |||
| // parse tolerations | |||
| tolerations := []corev1.Toleration{} | |||
| for _, elem := range zoneParams.Tolerations { | |||
| var tolerationSeconds *int64 | |||
| if elem.TolerationSeconds != nil { | |||
There was a problem hiding this comment.
won't the swagger API reject this?
There was a problem hiding this comment.
no because TolerationSeconds it is not required, the required one is seconds on TolerationSeconds, kind of weird because both are pointers but swagger doesn't validate this.
dvaldivia
approved these changes
Aug 8, 2020
Alevsk
approved these changes
Aug 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since toleration seconds can be empty, we were forcing it to be an integer defaulting to 0 which
was creating a toleration with value 0 when value should have been nil.
Request now changes to:
If tolerationSeconds exists it should be assigned to the Tenant instance with the desired value
If tolerationSeconds is not defined it should not assign any value on the Tenant instance and leave it empty.