-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Object Browser and Buckets Admin #2500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
cniackz,
reivaj05,
prakashsvmx,
kaankabalak,
bexsoft,
jinapurapu and
dilverse
December 12, 2022 20:13
dvaldivia
force-pushed
the
split-object-browser-admin
branch
from
December 13, 2022 00:00
fbf96c8
to
5ad5d45
Compare
Tests fixed in dvaldivia#5 |
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
dvaldivia
force-pushed
the
split-object-browser-admin
branch
from
December 14, 2022 23:07
e7b0d66
to
86e00b1
Compare
reivaj05
reviewed
Dec 14, 2022
reivaj05
approved these changes
Dec 14, 2022
bexsoft
approved these changes
Dec 15, 2022
All is looking good, my only concern is the failure at test: But maybe this isn't related as we are just changing the UI, right?. In any case, the log is:
and the code around is: // 7. Delete remaining Bucket Replication Rule with generic end point:
// /buckets/{bucket_name}/delete-all-replication-rules
response, err = DeletesAllReplicationRulesOnABucket(
originBucket,
)
assert.Nil(err)
if err != nil {
log.Println(err)
return
}
finalResponse = inspectHTTPResponse(response)
if response != nil {
assert.Equal(204, response.StatusCode, finalResponse)
} We can open another PR to fix this test |
cniackz
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the Object Browser and the Buckets Admin page
Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com