Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Object Browser and Buckets Admin #2500

Merged
merged 5 commits into from
Dec 15, 2022

Conversation

dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Dec 12, 2022

Split the Object Browser and the Buckets Admin page

Screenshot 2022-12-12 at 12 12 37 PM

Screenshot 2022-12-12 at 12 12 39 PM

Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com

@bexsoft
Copy link
Collaborator

bexsoft commented Dec 14, 2022

Tests fixed in dvaldivia#5

@dvaldivia dvaldivia removed the blocked label Dec 14, 2022
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@cniackz
Copy link
Collaborator

cniackz commented Dec 15, 2022

Tested locally:

image

@cniackz
Copy link
Collaborator

cniackz commented Dec 15, 2022

All is looking good, my only concern is the failure at test:

Screenshot 2022-12-14 at 6 17 55 PM

But maybe this isn't related as we are just changing the UI, right?.

In any case, the log is:

    user_api_bucket_test.go:2825: 
        	Error Trace:	/home/runner/work/console/console/integration/user_api_bucket_test.go:2825
        	Error:      	Not equal: 
        	            	expected: 204
        	            	actual  : 500
        	Test:       	TestReplication
        	Messages:   	Http Response: {"code":500,"detailedMessage":"The remote target does not exist","message":"an error occurred, please try again"}
--- FAIL: TestReplication (0.51s)

and the code around is:

	// 7. Delete remaining Bucket Replication Rule with generic end point:
	// /buckets/{bucket_name}/delete-all-replication-rules
	response, err = DeletesAllReplicationRulesOnABucket(
		originBucket,
	)
	assert.Nil(err)
	if err != nil {
		log.Println(err)
		return
	}
	finalResponse = inspectHTTPResponse(response)
	if response != nil {
		assert.Equal(204, response.StatusCode, finalResponse)
	}

We can open another PR to fix this test

Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit f557c4c into minio:master Dec 15, 2022
@dvaldivia dvaldivia deleted the split-object-browser-admin branch December 15, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants