Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve playwright tests with refactoring and clean up #2809

Merged
merged 3 commits into from May 15, 2023

Conversation

prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented May 9, 2023

improve playwright tests with refactoring and clean up

Currently running the test locally multiple times requires manual clean up ( removal of bucket once test verification step is done)

This PR adds clean up functionality and also the steps based tests.

to run/test locally,

# Terminal 1 Start MinIO
CI=true  MINIO_ROOT_USER=minioadmin MINIO_ROOT_PASSWORD=minioadmin minio server /tmp/site1{1...4}  --address ":9000" --console-address ":9001"


# Terminal ( start console server)
make install 
CONSOLE_MINIO_SERVER=http://localhost:9000 ./console server

# Terminal 3 ( run playwright tests)
cd portal-ui
npx playwright test

# To debug a specific test file via visual runner
npx playwright test lifecycle.spec.ts --ui

@cesnietor cesnietor self-requested a review May 12, 2023 18:10
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback, LGTM!

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 22ec87d into minio:master May 15, 2023
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants