Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Annotations, Labels and NodeSelector fields #285

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Sep 22, 2020

For Console/Encryption objects in the CreateTenant Api

@Alevsk Alevsk self-assigned this Sep 22, 2020
@dvaldivia
Copy link
Collaborator

you are not going to read the image from the console attribute? I see consoleCOnfiguration has the field in there

dvaldivia
dvaldivia previously approved these changes Sep 22, 2020
cesnietor
cesnietor previously approved these changes Sep 22, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is the console image property being used?

For Console/Encryption objects in the  CreateTenant Api
@Alevsk
Copy link
Contributor Author

Alevsk commented Sep 22, 2020

how is the console image property being used?

will be used in the future, in the meantime we can use the existing console_image so we dont break the frontend

@Alevsk
Copy link
Contributor Author

Alevsk commented Sep 22, 2020

you are not going to read the image from the console attribute? I see consoleCOnfiguration has the field in there

will be used in the future, in the meantime we can use the existing console_image so we dont break the frontend

@dvaldivia dvaldivia merged commit 86426e9 into minio:master Sep 22, 2020
@Alevsk Alevsk deleted the metadata-fields branch September 22, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants