Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename portal-ui to web-app #3178

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Conversation

dvaldivia
Copy link
Collaborator

To keep the naming of the web app across projects consistent we are renaming portal-ui to web-app

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't we just call it ui/ ?

@dvaldivia
Copy link
Collaborator Author

@harshavardhana we could but we call it web-app everywhere else xD

@dvaldivia dvaldivia merged commit 239b317 into minio:master Dec 29, 2023
30 checks passed
@dvaldivia dvaldivia deleted the rename-portal-ui-web-app branch December 29, 2023 17:44
@djwfyi djwfyi mentioned this pull request Jan 11, 2024
2 tasks
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants