Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use swagger api for delete group #3196

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

cesnietor
Copy link
Collaborator

@cesnietor cesnietor commented Jan 17, 2024

It also catches correctly the error and shows it as snackbar.
Screenshot 2024-01-17 at 11 01 29 AM

Test Steps:

  1. Go to Administrator/Identity/Groups

  2. Add a group with users

  3. Delete the group (error should show as snack bar)

  4. Add a group without users

  5. Delete group (group should be deleted and list of groups regreshed.)

bexsoft
bexsoft previously approved these changes Jan 17, 2024
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit edaa4e8 into minio:master Jan 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants