Add download objects api and integrate it with UI #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Oct 8, 2020
cesnietor
force-pushed
the
download-api
branch
from
f45b825
to
df3b712
Compare
dvaldivia
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds single object download api
It also integrates it with the objects list UI.
Can be called doing
GET:http://localhost:{{mcsport}}/api/v1/buckets/<bucket_name>/objects/download?prefix=<file_prefix>Test Notes:
Add some objects to your bucket and make sure you can download the object with no errors using the UI.
Note: Requires authenticated request.