Fix folder download #3264
Merged
Fix folder download #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to verify the fileSize to ensure the object was fully downloaded but we don't get the fileSize for folder downloads so we can't do that check.
reivaj05
previously approved these changes
Mar 14, 2024
cesnietor
force-pushed
the
fix-folder-download
branch
from
4ebbf9e
to
52b043e
Compare
bayasdev
approved these changes
Mar 14, 2024
|
why do these permission tests keep failing? |
They started failing with previous PRs we'll take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3263
context: #3249
We used to verify the fileSize to ensure the object was fully downloaded but we don't get the fileSize for folder downloads so we can't do that check.
Test Steps: