Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default Replicate Existing Objects behavior in MinIO UI #3271

Merged
merged 3 commits into from
May 6, 2024

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Mar 20, 2024

fixes #3181

What does this do?

  • Fixed replicate existing objects configuration saving
  • Displayed full error message if error case ocurrs.
  • Changed wording for this feature & enabled by default this setting

How does it look?

Screenshot 2024-05-05 at 12 19 49 a m Screenshot 2024-05-05 at 12 24 14 a m

@bexsoft bexsoft self-assigned this Mar 20, 2024
@bexsoft bexsoft changed the title Changed default Replicate Existing Objects behavior in UI Changed default Replicate Existing Objects behavior in MinIO UI Mar 20, 2024
@poornas
Copy link

poornas commented Mar 20, 2024

mc replicate add turns on existing-objects replication by default if --replicate flag is not specified. The console enabling of existing objects by default is consistent with that - it is just the docs link above and wording displayed on console that needs to change to reflect that

@bexsoft
Copy link
Collaborator Author

bexsoft commented Mar 20, 2024

mc replicate add turns on existing-objects replication by default if --replicate flag is not specified. The console enabling of existing objects by default is consistent with that - it is just the docs link above and wording displayed on console that needs to change to reflect that

I see, Including @ravindk89 in the loop for this

@bexsoft bexsoft requested a review from ravindk89 March 20, 2024 17:28
@bexsoft bexsoft marked this pull request as draft March 20, 2024 17:28
@bexsoft bexsoft closed this May 5, 2024
@bexsoft bexsoft reopened this May 5, 2024
@bexsoft bexsoft force-pushed the existing-object-replicate branch from 07a2a10 to baac748 Compare May 5, 2024 06:12
- Fixed replicate existing objects configuration saving
- Displayed full error message if error case ocurrs.
- Changed wording for this feature & enabled by default this setting

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft force-pushed the existing-object-replicate branch from baac748 to c2baad9 Compare May 5, 2024 06:24
@bexsoft bexsoft marked this pull request as ready for review May 5, 2024 06:25
@bexsoft bexsoft merged commit 22fe915 into minio:master May 6, 2024
33 checks passed
@bexsoft bexsoft deleted the existing-object-replicate branch May 6, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replicating existing files is the default behavior in Bucket Replication.
4 participants