Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs delete bucket event notification api #36

Merged
merged 6 commits into from Apr 7, 2020

Conversation

cesnietor
Copy link
Collaborator

@cesnietor cesnietor commented Apr 6, 2020

To delete do DELETE on /api/v1/buckets/{bucket_name}/events/{arn_name}
Response will be empty if successful. Returns same errors as minio/mc.

swagger.yml Show resolved Hide resolved
@cesnietor cesnietor self-assigned this Apr 6, 2020
@cesnietor cesnietor requested a review from dvaldivia April 6, 2020 20:04
@cesnietor cesnietor force-pushed the mcs-delete-bucket-event-api branch from 84c8acc to 2ab8036 Compare April 6, 2020 20:25
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good & works fine for me

Screen Shot 2020-04-06 at 9 18 35 PM

@dvaldivia
Copy link
Collaborator

@bexsoft my only concern is that it deletes all the events for the bucket, regardless, I created a PR for mc so we can delete only 1 event minio/mc#3145

Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's take this in, and update it with the new behavior when it's merged to mc

@dvaldivia dvaldivia merged commit e0bb098 into minio:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants