-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connected object tags API #421
Conversation
9498dc2
to
4854f13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that we set the same value on key
and value
but minio allows them to be different, so if the object has tags already set by mc we would show only one value:
mc tag list s3/testbucket/testobject
Name : testobject
editable : only-by-owner-and-authenticated
confidentiality : open-to-authenticated-only
we might need to change to show/set both key and values.
@cesnietor would showing that need some changes to the UI? |
yes probably a redesign or do a |
@cesnietor @dvaldivia But in this case what would be the purpose of showing the key too?, wouldn't it be better to make the labels as string arrays? I think people would be used to look for complete phrases rather than key values |
yes, I agree, but since we mirror mc's behavior we need to do an equivalent thing. Also it is an AWS thing https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html |
716085f
to
fc30008
Compare
Added changed to be S3 Compliant: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested LGTM
What does this do?
Connects object tags API to object details screen.
NOTE: There is a small delay between tag changes after saving any modification, will fix this after adding loaders to object details page.
How does it look?