Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New design for subscription page #568

Merged
merged 3 commits into from Feb 5, 2021
Merged

New design for subscription page #568

merged 3 commits into from Feb 5, 2021

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Jan 20, 2021 •
edited

@Alevsk Alevsk self-assigned this Jan 20, 2021
@Alevsk Alevsk requested a review from bexsoft January 20, 2021 08:01
@Alevsk Alevsk added the WIP This PR is WIP and cannot be merged yet label Jan 20, 2021
@Alevsk Alevsk force-pushed the license-page-design branch 2 times, most recently from f59dcfa to 5fb8887 Compare January 25, 2021 18:56
@Alevsk Alevsk force-pushed the license-page-design branch 2 times, most recently from fd476db to e7d469d Compare January 28, 2021 07:12
@Alevsk Alevsk removed the WIP This PR is WIP and cannot be merged yet label Jan 28, 2021
dvaldivia
dvaldivia previously approved these changes Jan 28, 2021
View reviewed changes
bexsoft
bexsoft requested changes Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments bellow:

portal-ui/src/screens/Console/License/ActivationModal.tsx
licenseKeyField: {
marginBottom: 20,
},
licenseKeyField: {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's empty we can remove

@bexsoft
Copy link
Collaborator

bexsoft commented Jan 28, 2021

Screen Shot 2021-01-28 at 13 01 23

Can we remove the opacity effect?, also the activate button should be greyed out when one field is empty to have consistency

@bexsoft
Copy link
Collaborator

bexsoft commented Jan 28, 2021

Screen Shot 2021-01-28 at 13 03 07

Can we remove the borders & styles for activate button?

@bexsoft
Copy link
Collaborator

bexsoft commented Jan 28, 2021

Can we please make portal-ui/public/agpl.png to be a svg file?

@dvaldivia dvaldivia merged commit 7174892 into minio:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft bexsoft approved these changes

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@cesnietor cesnietor Awaiting requested review from cesnietor

Assignees

@Alevsk Alevsk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alevsk @bexsoft @dvaldivia