Fixed some issues with dashboard #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, it just have some compilation warnings |
Alevsk
previously approved these changes
Jan 21, 2021
| return JSON.parse(atob(storedConfiguration)); | ||
| const parsedConfig = JSON.parse(atob(storedConfiguration)); | ||
|
|
||
| if (!parsedConfig[0].minW) { |
There was a problem hiding this comment.
should we validate here that parsedConfig.length > 0 ?
There was a problem hiding this comment.
we define that value internally to position the widgets, it will always contain a first element unless we delete it
There was a problem hiding this comment.
added an extra validation
bexsoft
force-pushed
the
style-improvements-dashboard
branch
from
0dd113c
to
a0d4c76
Compare
fixed |
bexsoft
force-pushed
the
style-improvements-dashboard
branch
from
a0d4c76
to
d091119
Compare
Alevsk
previously approved these changes
Jan 22, 2021
Alevsk
previously approved these changes
Jan 23, 2021
-Added padding to the bottom of dashboard -Added calculations for linear chart tick interval -Added default min width configurations to panels. - Fixed crash on clean tenant
bexsoft
force-pushed
the
style-improvements-dashboard
branch
from
60eed86
to
94c18dd
Compare
Alevsk
approved these changes
Jan 25, 2021
cesnietor
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Fixed some issues with dashboard UX
-Added padding to the bottom of dashboard
-Added calculations for linear chart tick interval
-Added default min width configurations to panels.
-Fixed potential crash with clean tenants
How does it look?