Fix Tenant Details Bugs #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
requested changes
Feb 3, 2021
Alevsk
previously approved these changes
Feb 4, 2021
bexsoft
requested changes
Feb 4, 2021
dvaldivia
force-pushed
the
fix-tenant-add-bugs
branch
2 times, most recently
from
06ec5bd
to
4f0de87
Compare
cesnietor
approved these changes
Feb 5, 2021
dvaldivia
force-pushed
the
fix-tenant-add-bugs
branch
from
4f0de87
to
7cafab1
Compare
Alevsk
approved these changes
Feb 5, 2021
cesnietor
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #584 by making the expand set a name for the pool
This fixes #585 by making the expand set an affinity for the pool
This fixes #586 by generating a pool name if it's not indicated only
Also adds namespace to the list of columns of tenant