Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed max size for widgets #624

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Mar 3, 2021

fixes #587

What does this do?

Fixed max-widget sizes for prometheus dashboard on high-res screens

How does it look?

Screen Shot 2021-03-03 at 13 30 07

Screen Shot 2021-03-03 at 13 29 11

@bexsoft bexsoft added enhancement New feature or request UI User Interface labels Mar 3, 2021
@bexsoft bexsoft self-assigned this Mar 3, 2021
@bexsoft bexsoft added this to Review In Progress in Console 1.1 via automation Mar 3, 2021
@dvaldivia
Copy link
Collaborator

is this similar to how graphana scales the widges?

Alevsk
Alevsk previously approved these changes Mar 3, 2021
cesnietor
cesnietor previously approved these changes Mar 4, 2021
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested LGTM

Console 1.1 automation moved this from Review In Progress to Reviewer Approved Mar 4, 2021
@bexsoft
Copy link
Collaborator Author

bexsoft commented Mar 4, 2021

is this similar to how graphana scales the widges?

Yes for the Y-axis, on the X-axis they allow to increment the width to the max but they don't change the number of points that they're plotting. I added a restriction to avoid that resize because graphs doesn't look good when they wider

Screen.Recording.2021-03-03.at.19.41.15-hevcmp4.mp4

@bexsoft bexsoft dismissed stale reviews from cesnietor and Alevsk via 127669c March 4, 2021 23:08
Console 1.1 automation moved this from Reviewer Approved to Review In Progress Mar 4, 2021
Copy link
Contributor

@Alevsk Alevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Console 1.1 automation moved this from Review In Progress to Reviewer Approved Mar 5, 2021
@dvaldivia dvaldivia merged commit 716aabe into minio:master Mar 5, 2021
Console 1.1 automation moved this from Reviewer Approved to Done Mar 5, 2021
@bexsoft bexsoft deleted the max-height-dashboard branch June 14, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI User Interface
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add max-height limit to widgets in prometheus dashboard
4 participants