Returning correct error when user is unable to change password #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Mar 9, 2021
bexsoft
approved these changes
Mar 9, 2021
Alevsk
force-pushed
the
issue-631
branch
2 times, most recently
from
1256850
to
f236e26
Compare
dvaldivia
previously approved these changes
Mar 9, 2021
|
might need to remake assets due to previous merge |
bexsoft
approved these changes
Mar 9, 2021
|
Why not disable the UI element entirely? |
good idea, adding support to enable/disable specific UI elements and not only options at the menu, with this we will improve UX for console users |
bexsoft
requested changes
Mar 10, 2021
- Returning correct error when user is unable to change password - Added support for enable/disable UI elements based on allowed apis
bexsoft
approved these changes
Mar 10, 2021
cesnietor
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When password change fails because of permissions/policies
When password change fails because of incorrect current password
Change password is enabled
Change password is disabled