Show object versions on UI only when bucket has versioning enabled #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Mar 9, 2021
cesnietor
force-pushed
the
object-list-versions
branch
from
b56c971
to
78d9f55
Compare
dvaldivia
approved these changes
Mar 10, 2021
bexsoft
approved these changes
Mar 10, 2021
got it thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #594
If bucket doesn't have versioning enabled, objects shouldn't show component that lists versions.
To test:
Create a bucket without versioning, add an object and on the object details the list shouldn't appear.
Create a bucket with versioning, add an object and on the object details the list should appear.