New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding list of pods #715
Adding list of pods #715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See screenshot
{selectedTab === 2 && pods[0].time && ( | ||
<TableWrapper | ||
itemActions={[ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The delete action is not yet implemented, please remove this option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can send an empty array to item actions, it is not necessary to have an option here always
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can send an empty array to item actions, it is not necessary to have an option here always
Can you also attach a screenshot of the final screen to this ticket |
@@ -28,6 +28,16 @@ export interface IPool { | |||
label?: string; | |||
} | |||
|
|||
export interface IPod { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should call it IPodListElement
to have more clarity on what does this interface do
result[i].time = niceDays( | ||
(currentTime - parseInt(result[i].timecreated)).toString() | ||
); | ||
console.log(result[i]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove console.log
{selectedTab === 2 && pods[0].time && ( | ||
<TableWrapper | ||
itemActions={[ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can send an empty array to item actions, it is not necessary to have an option here always
{selectedTab === 2 && pods[0].time && ( | ||
<TableWrapper | ||
itemActions={[ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can send an empty array to item actions, it is not necessary to have an option here always
swagger.yml
Outdated
status: | ||
type: | ||
string | ||
timecreated: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use camel case:
timecreated: | |
timeCreated: |
swagger.yml
Outdated
string | ||
timecreated: | ||
type: integer | ||
podip: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same camel case here:
podip: | |
podIP: |
.then((result: IPod[]) => { | ||
for (let i = 0; i < result.length; i++) { | ||
let currentTime = new Date().getSeconds(); | ||
console.log(currentTime); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove console.log
let currentTime = new Date().getSeconds(); | ||
console.log(currentTime); | ||
result[i].time = niceDays( | ||
(currentTime - parseInt(result[i].timecreated)).toString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restapi/admin_tenants.go
Outdated
} | ||
retval := []*models.TenantPod{} | ||
for i := range pods.Items { | ||
if pods.Items[i].Name[0:len(params.Tenant)] == params.Tenant { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I broke this logic by deploying a pod for wodpress with the tenant prefix
admin.json
Outdated
@@ -0,0 +1,22 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file
restapi/admin_tenants.go
Outdated
return nil, prepareError(err) | ||
} | ||
listOpts := metav1.ListOptions{ | ||
TypeMeta: metav1.TypeMeta{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all unused fields, also this doesn't filter anything like we discussed
portal-ui/src/screens/Console/Tenants/TenantDetails/TenantDetails.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Tenants/TenantDetails/TenantDetails.tsx
Outdated
Show resolved
Hide resolved
…ils.tsx Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com>
…ils.tsx Co-authored-by: Alex <33497058+bexsoft@users.noreply.github.com>
No description provided.