Add Create Service Account api #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
force-pushed
the
add-service-accounts-api
branch
from
9857f90
to
6b7dc7f
Compare
cesnietor
changed the title
cesnietor
force-pushed
the
add-service-accounts-api
branch
from
6b7dc7f
to
b5fd8f2
Compare
cesnietor
changed the title
dvaldivia
previously approved these changes
Apr 29, 2020
bexsoft
requested changes
Apr 29, 2020
cesnietor
force-pushed
the
add-service-accounts-api
branch
from
b5fd8f2
to
aa15a98
Compare
adds new functionality for creating a service account for a user, for this, an admin client is created with the user credentials so that the service account can be assigned to him. This also updates to minio RELEASE.2020-04-28T23-56-56Z
cesnietor
force-pushed
the
add-service-accounts-api
branch
from
aa15a98
to
81d691c
Compare
|
Tested, works good 👍 |
@Alevsk can you please remove you request change? XD |
Alevsk
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds new functionality for creating a service
account for a user, for this, an admin client
is created with the user credentials so that
the service account can be assigned to him.
To test this:
create a user and assign a policy to him
login to mcs with the user credentials
create a serviceAccount on
/api/v1/service-accountsThe payload can (optional) have a policy defined as string e.g.
it should return the Service Account credentials like:
Test that the Service Account can be added as a new host and have the proper permissions