Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables replacement in mcs #74

Merged
merged 1 commit into from Apr 21, 2020
Merged

Tables replacement in mcs #74

merged 1 commit into from Apr 21, 2020

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Apr 21, 2020

What does this do?

Replaced all the tables in mcs to be consistent with the new design

How to test

Go into each section and check that all the information is shown correctly and the table interactions doesn't get broken

@bexsoft bexsoft self-assigned this Apr 21, 2020
dvaldivia
dvaldivia previously approved these changes Apr 21, 2020
@cesnietor
Copy link
Collaborator

Not sure if part of this pr. when there is no group selected on creation of a user the group parameter needs to be sent as empty []
Screen Shot 2020-04-21 at 11 31 35 AM

@cesnietor
Copy link
Collaborator

cesnietor commented Apr 21, 2020

After deletion of a user the page doesn't update:
Screen Shot 2020-04-21 at 11 32 25 AM
After delete:
Screen Shot 2020-04-21 at 11 32 31 AM

@cesnietor
Copy link
Collaborator

cesnietor commented Apr 21, 2020

When I try to edit a bucket this breaks.
Screen Shot 2020-04-21 at 11 32 51 AM

@cesnietor
Copy link
Collaborator

After deletion of a single bucket, the page doesn't load.
Screen Shot 2020-04-21 at 11 35 05 AM

@bexsoft
Copy link
Collaborator Author

bexsoft commented Apr 21, 2020

Not sure if part of this pr. when there is no group selected on creation of a user the group parameter needs to be sent as empty []
Screen Shot 2020-04-21 at 11 31 35 AM

Seems like mc is now returning null when the users list is empty instead of an empty array like it used to do before. Fixed issue

@bexsoft
Copy link
Collaborator Author

bexsoft commented Apr 21, 2020

After deletion of a user the page doesn't update:
Screen Shot 2020-04-21 at 11 32 25 AM
After delete:
Screen Shot 2020-04-21 at 11 32 31 AM

This seems to be an old issue, it only happens when you have one only one user in the list and you want to delete it, Will file a new issue for this

@bexsoft
Copy link
Collaborator Author

bexsoft commented Apr 21, 2020

When I try to edit a bucket this breaks.
Screen Shot 2020-04-21 at 11 32 51 AM

Fixed. same issue as cannot update user

@bexsoft
Copy link
Collaborator Author

bexsoft commented Apr 21, 2020

After deletion of a single bucket, the page doesn't load.
Screen Shot 2020-04-21 at 11 35 05 AM

Fixed

cesnietor
cesnietor previously approved these changes Apr 21, 2020
Replaced all the tables in mcs to be consistent with the new design
@dvaldivia dvaldivia merged commit d9c212f into minio:master Apr 21, 2020
@bexsoft bexsoft deleted the tables-replace-pr branch May 8, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants