#616 added modal on icon click #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested changes
May 17, 2021
| @@ -93,6 +93,7 @@ export interface MakeBucketRequest { | |||
| } | |||
|
|
|||
| export interface ChangePasswordRequest { | |||
| //selected_user: object; | |||
There was a problem hiding this comment.
if this line is not needed, remove it
restapi/user_account.go
Outdated
| // changeUserPassword validate current current user password and if it's correct set the new password | ||
| // WHAT SHOULD IT DO? just set the new password, assuming this is for locked out users, current password may be unknown, only Admin users can use this function, should it use 2factor/email? | ||
| func changeUserPassword(ctx context.Context, client MinioAdmin, session *models.Principal, currentSecretKey, newSecretKey string) error { | ||
| if session.AccountSecretKey != currentSecretKey { |
There was a problem hiding this comment.
we probably don't have the user's current password, so we shouldn't require this field
dvaldivia
requested changes
May 17, 2021
bindata.go
Outdated
| @@ -0,0 +1,10 @@ | |||
|
|
|||
There was a problem hiding this comment.
please remove this file
There was a problem hiding this comment.
any bindata file mnust be removed from this PR
dvaldivia
reviewed
May 18, 2021
jinapurapu
force-pushed
the
change_PW_icon
branch
2 times, most recently
from
183d23c
to
0511abf
Compare
bexsoft
requested changes
May 19, 2021
| interface IChangePasswordProps { | ||
| classes: any; | ||
| open: boolean; | ||
| // selectedUser: User | null; |
| const ChangePassword = ({ | ||
| classes, | ||
| open, | ||
| //selectedUser, |
There was a problem hiding this comment.
We can remove this line if not needed
| setLoading(true); | ||
|
|
||
| let request: ChangeUserPasswordRequest = { | ||
| //selected_user: selectedUser, |
| .invoke("POST", "/api/v1/account/change-user-password", request) | ||
| .then((res) => { | ||
| setLoading(false); | ||
| // setSelectedUser(""); |
| loading || | ||
| !( | ||
| newPassword.length > 0 && | ||
| reNewPassword.length > 0 |
There was a problem hiding this comment.
we can add another condition to disable the button if passwords don't match
Suggested change
| reNewPassword.length > 0 | |
| reNewPassword.length > 0 && newPassword !== reNewPassword |
| @@ -189,7 +189,7 @@ const Groups = ({ classes, setErrorSnackMessage }: IGroupsProps) => { | |||
| <Grid item xs={12} className={classes.container}> | |||
| <Grid item xs={12} className={classes.actionsTray}> | |||
| <TextField | |||
| placeholder="Search Groups" | |||
| placeholder="Search " | |||
There was a problem hiding this comment.
I think this label should not be removed
|
Please review: |
jinapurapu
force-pushed
the
change_PW_icon
branch
3 times, most recently
from
430c00b
to
5957b75
Compare
dvaldivia
requested changes
Jun 1, 2021
restapi/admin_users.go
Outdated
| } | ||
| // user credentials are updated at this point, we need to generate a new admin client and authenticate using | ||
| // the new credentials | ||
| //credentials, err := getConsoleCredentials(ctx, accessKey, newSecretKey) |
There was a problem hiding this comment.
remove commented code if not needed
|
|
add icon to Users page to change password commit work to date to github for ongoing use add modal with fields for current and new password on icon click missing swagger files remove unneeded files move changeUserPassword to admin_api, remove field for current password, include selected user Please enter the commit message for your changes. Lines starting added missing js files asset and function signature formatting changes
selectedUser to modal text
…emoved commented out code
add icon to Users page to change password commit work to date to github for ongoing use add modal with fields for current and new password on icon click missing swagger files remove unneeded files move changeUserPassword to admin_api, remove field for current password, include selected user Please enter the commit message for your changes. Lines starting added missing js files asset and function signature formatting changes
selectedUser to modal text
jinapurapu
force-pushed
the
change_PW_icon
branch
from
5c7108a
to
a158acb
Compare
bexsoft
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon clicking the pencil icon, a modal opens with fields for current password, new password, and to reenter the new password. The modal is largely a copy of the ChangePassword modal, and requires further modification to pass the selected user, and change the selected users password.
fixes https://github.com/miniohq/engineering/issues/3